SAK-51274 Portal fix keyboard nav inside portal-main-content #13562
Conversation
| @@ -28,8 +28,8 @@ | |||
| #else | |||
| #set( $numberTools = $pageColumn0Tools.size() ) | |||
| #end | |||
| <div class="portal-main-container container-fluid pt-4 d-flex flex-column"> | |||
There was a problem hiding this comment.
d-flex was added in SAK-50454 Polls improve voting ui responsiveness (#12856)
|
Great, thank you!! |
|
You're welcome, but I know very little about CSS grid systems. You likely know far more than I do so can help figure out what's going on here. |
|
I'll apply tomorrow morning in our QA server and I'll tell you what I see |
|
Hi, @jorgecanovas and I have been testing the changes and the only thing is that you need to have the grid area active (filling a form or clicking on the tool) for the keys to work, just like if you have the menu active it works for the menu, so I see it fine. We can discuss, later, if we remove the CSS Grid and leave it as a block, but, if it was since 23 and nobody has complained about this issue, I think this solution is great and fixes the main problem. LGTM |
Right, you have to be working inside that area for the scroll to work. That seems correct to me.
I don't have an allegiance to CSS Grids, but the entire Trinity portal seems dependent on the grid. I'm not sure what it would take, but it sounds like a big project. |
|
Yes, too big :D |
(cherry picked from commit 685dab4)
(cherry picked from commit 685dab4) Conflicts: portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePage.vm
No description provided.